Skip to content
This repository was archived by the owner on Jan 14, 2023. It is now read-only.

Conversation

@Spring3
Copy link
Owner

@Spring3 Spring3 commented Oct 30, 2021

Re-shaped the structure of settings that the application stores locally.

Migrated settings to overmind, as well as to the main thread only. So, with this PR render thread won't try to access settings directly, but instead will request them from the main thread, following the same pattern as http requests.

The data structure of the settings (at the time of writing, will look like the following):

{
  activeSession: {
    user: {
      id: '',
      firstName: '',
      lastName: '',
      createdOn: '',
    },
    endpoint: '',
    hash: '',
    settings: {
      ...
    }
  },
  persistedSessions: [{
    user: {
      id: '',
      firstName: '',
      lastName: '',
      createdOn: '',
    },
    endpoint: '',
    hash: '',
    settings: {
      ...
    }
  }, {
    user: {
      id: '',
      firstName: '',
      lastName: '',
      createdOn: '',
    },
    endpoint: '',
    hash: '',
    settings: {
      ...
    }
  }]
}

Things to do:

  • verify that the sessions are saved when logged in / out
  • verify that the last active session gets restored and the user doesn't have to log in repeatedly

@Spring3 Spring3 self-assigned this Oct 30, 2021
@Spring3 Spring3 merged commit 1f3db3a into develop Nov 7, 2021
@Spring3 Spring3 deleted the refactor/migrate-settings branch November 7, 2021 03:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants