Skip to content

refactor: stop calling spring_config_default() #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2022
Merged

refactor: stop calling spring_config_default() #43

merged 2 commits into from
Jun 9, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Jun 9, 2022 •
edited
Loading

Issue number and link

Describe your changes

I will remove fn spring_config_default() in SpringQL repo.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

laysakura
laysakura commented Jun 9, 2022
View reviewed changes
src/lib.rs
#[no_mangle]
pub unsafe extern "C" fn spring_column_float(
row: *const SpringRow,
row: *const SpringRow,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just format

@laysakura laysakura marked this pull request as ready for review June 9, 2022 08:16
@laysakura laysakura requested a review from kazuk June 9, 2022 08:16
@laysakura laysakura merged commit b9e0ca1 into main Jun 9, 2022
@laysakura laysakura deleted the refactor/stop-using-old-apis branch June 9, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuk kazuk Awaiting requested review from kazuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laysakura