Skip to content

refactor: stop calling spring_config_default() #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

refactor: stop calling spring_config_default() #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14957a7
refactor: stop calling spring_config_default()
laysakura Jun 9, 2022
022cd1d
docs: add CHANGELOG
laysakura Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Also check the changes in springql-core: <https://github.com/SpringQL/SpringQL/b
<!-- markdownlint-disable MD024 -->
## [Unreleased]

### For developers

- refactor: stop calling spring_config_default(). ([#43](https://github.com/SpringQL/SpringQL-client-c/pull/43))

## [v0.11.0]

### For developers
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use ::springql_core::api::{error::SpringError, SpringPipeline as Pipeline};
/// If you would like to change the default configuration, use `spring_config_toml()` instead.
#[no_mangle]
pub extern "C" fn spring_config_default() -> *mut SpringConfig {
let config = ::springql_core::api::spring_config_default();
let config = ::springql_core::api::SpringConfig::default();
SpringConfig::new(config).into_ptr()
}

Expand Down Expand Up @@ -413,7 +413,7 @@ pub unsafe extern "C" fn spring_column_bool(
/// - `CNull`: Column value is NULL.
#[no_mangle]
pub unsafe extern "C" fn spring_column_float(
row: *const SpringRow,
row: *const SpringRow,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just format

i_col: u16,
out: *mut c_float,
) -> SpringErrno {
Expand Down