Feature/187293354 - Pixi 8 update #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. `game.js` now dispatches an event before `.run` is called by `index.js`
…ge in how `update` `deltaTime` is passed along.
jeremymccurdy-redspace
requested review from
902seanryan,
TensAndTwenties,
corinnejean and
selenaqian
corinnejean
reviewed
Apr 30, 2024
corinnejean
left a comment
corinnejean
left a comment
There was a problem hiding this comment.
Just one comment! I will approve once we officially figure out the versioning
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [1.4.0] - TBD |
There was a problem hiding this comment.
I believe we are going to bump this and all the other ones to 2.0.0 since we have some potentially breaking changes here
Collaborator
Author
There was a problem hiding this comment.
I've made a PR to update the package version and changelog in the 2.0.0 release branch: #111
I noticed there was a slight difference between the changelog on main and the one in the templates. This change will keep it all consistent, and it just needs to be pulled into the template branches.
This was referenced May 2, 2024
selenaqian
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings Pixi.js up to version
8.1.0and Pixi sound up to2.4.4Changes:
tickerupdates (the update loop) passes along a reference to the ticker object instead of justdeltaTime, so this has been updated to match.Ticket: https://www.pivotaltracker.com/story/show/187293354