Skip to content
This repository was archived by the owner on Jul 2, 2020. It is now read-only.

Conversation

@akerstrom
Copy link
Contributor

No description provided.

@akerstrom akerstrom requested a review from jishi September 8, 2017 09:56
@jishi
Copy link

jishi commented Sep 8, 2017

I was under the impression that this was to be added to the (non-existent) ts-hapi generator? I see no real benefit adding very specific generators like this, if the wire-up will need to consist of running multiple generators.

@sommestad
Copy link
Contributor

sommestad commented Sep 13, 2017

This approach has been very useful for the other Node projects we've set up. Partly because it makes the generators useful for projects with other existing set up. And not all projects are Hapi APIs, for example.

Some people prefer a bigger generator, some several smaller modular ones...

But it is also possible to combine the output of multiple generators if that's preferred by some (either as another generator or to just combine the commands).

{
"extends": "@springworks/tslint-config",
"rules": {
"no-unused-expression": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule should not go in here. If it's supposed to be included, it should be in the tslint-config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, will fix.

@akerstrom akerstrom changed the title chore: add generator for TypeScript linting (DO NOT MERGE) chore: add generator for TypeScript linting Sep 13, 2017
@akerstrom akerstrom force-pushed the add-linting-generator-for-typescript branch from e25194e to 139aaad Compare September 14, 2017 11:13
@akerstrom akerstrom force-pushed the add-linting-generator-for-typescript branch from 139aaad to 44a18e5 Compare September 14, 2017 13:18
@akerstrom akerstrom changed the title (DO NOT MERGE) chore: add generator for TypeScript linting chore: add generator for TypeScript linting Sep 14, 2017
@akerstrom akerstrom merged commit fa111e5 into master Sep 15, 2017
@akerstrom akerstrom deleted the add-linting-generator-for-typescript branch September 15, 2017 06:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants