Skip to content

Ensure messages are non-null #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2013
Merged

Ensure messages are non-null #4

merged 1 commit into from
Feb 13, 2013

Conversation

@kryali
Copy link

@kryali kryali commented Feb 13, 2013

Checks

  1. error.message()
  2. logMessage
  3. 'No message'

JakeWharton
JakeWharton reviewed Feb 13, 2013
View reviewed changes
src/main/java/com/squareup/squash/SquashEntry.java Outdated
Copy link
Contributor

@JakeWharton JakeWharton Feb 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static?

Ensure messages are non-null
9a4f468 
Checks
1. error.message()
2. logMessage
3. 'No message'
JakeWharton
JakeWharton reviewed Feb 13, 2013
View reviewed changes
src/test/java/com/squareup/squash/SquashEntryTest.java
Copy link
Contributor

@JakeWharton JakeWharton Feb 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7nTnr

Except @edenman wrote all this :)

edenman added a commit that referenced this pull request Feb 13, 2013
@edenman
Merge pull request #4 from SquareSquash/kiran/message-null
4c8192a 
Ensure messages are non-null
@edenman edenman merged commit 4c8192a into master Feb 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kryali @JakeWharton @edenman