-
-
Notifications
You must be signed in to change notification settings - Fork 77
Stac Framework Enhancements: Navigation, Borders, Colors & Architecture Improvements #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8b6a7c9
refactor: migrate StacDefaultBottomNavigationController to stac_core
Potatomonsta 5ab1df6
fix: change StacSetValueAction.action type from Map to StacAction
Potatomonsta 5241e45
feat: add .all and .symmetric factory methods to StacBorder
Potatomonsta 276547b
feat: add factory constructors to StacBorderRadius
Potatomonsta fa00e73
fix: defer BottomNavigationScope access to build time in navigation p…
Potatomonsta 158e011
feat: add withOpacity extension method to StacColor
Potatomonsta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
.../stac_default_bottom_navigation_controller/stac_default_bottom_navigation_controller.dart
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify null safety for the action invocation.
The change from
Stac.onCallFromJson(model.action, context)
tomodel.action.parse(context)
introduces a potential null pointer exception. Sincemodel.action
is typed asStacAction?
(nullable), calling.parse(context)
directly will throw ifaction
is null.Consider applying this diff to handle the null case safely:
Alternatively, verify whether
model.action
is guaranteed to be non-null in practice by running the following script:🏁 Script executed:
Length of output: 4220
📝 Committable suggestion
🤖 Prompt for AI Agents