Add option to format as systemd statements #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magickatt
approved these changes
Jul 18, 2023
|
Yeah, normally I would add unit tests but I haven't found an optimal strategy for this yet as it relies on files and the AWS API. I'm sure there's a way, I just don't want to have to mock things. Maybe it would make sense to have a special EC2 machine that is set up specifically for testing. Though I suppose you could also test the manager functions separately, particularly those that don't rely on files or AWS. The command-line functions, however, might need to think a bit more about, I'm sure there's a way though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.