Skip to content

Connections: don't open by default #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Connections: don't open by default #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a20a4
DisposeDB: handle background context cases
Aug 19, 2020
61d0def
Connections: don't auto-open
Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions App/StackExchange.DataExplorer/Current.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ public static DataExplorerDatabase DB
cnn = new ProfiledDbConnection(cnn, new ErrorLoggingProfiler(profiler));
}

cnn.Open();
result = DataExplorerDatabase.Create(cnn, 30);
if (Context != null)
{
Expand All @@ -191,7 +190,7 @@ public static void DisposeDB()
db?.Dispose();
Context.Items["DB"] = null;
}
else
// Also clear the call context DB if we ever hit it in a background thread
{
var db = CallContext.GetData("DB") as DataExplorerDatabase;
db?.Dispose();
Expand Down