Update Cluster AutoDiscovery after failover#1684
Merged
NickCraver merged 2 commits intoStackExchange:mainfrom Jun 15, 2021
Merged
Conversation
The following commits address: StackExchange#1659 Where basically after manual failover the replicas endpoint list is not refreshed. ServerSelectionStrategy.cs Updated: - SetClusterConfiguration to call new method UpdateNodeRelations with the configuration Added: - UpdateNodeRelations to have the same update logic that it was before in SetClusterConfiguration so it could be used in ConnectionMultiplexer ConnectionMultiplexer.cs Updated: - GetEndpointsFromClusterNodes, to call UpdateNodeRelations and refresh the configuration before returning the endpoints list
NickCraver
approved these changes
Jun 15, 2021
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Verified the symptoms locally and explains one test condition - pulling in!
Thank you!!
Collaborator
|
@TimLovellSmith @philon-msft can disregard here, we're good to go on next release, was able to (accidentally) cause the case this is resolving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following commits address: #1659
Where basically after manual failover the replicas endpoint list is
not refreshed.
ServerSelectionStrategy.cs
Updated:
the configuration
Added:
before in SetClusterConfiguration so it could be used in
ConnectionMultiplexer
ConnectionMultiplexer.cs
Updated:
refresh the configuration before returning the endpoints list