Support LMOVE#2065
Conversation
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
|
@Avital-Fine for tests, check out the format |
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Thank you! hope the merge won't be too bad 😅 |
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
A few tweaks/removals then I think we're good to go - thanks for this!
|
|
||
| public RedisValue ListMove(RedisKey sourceKey, RedisKey destinationKey, ListSide whereFrom, ListSide whereTo, CommandFlags flags = CommandFlags.None) | ||
| { | ||
| var msg = Message.Create(Database, flags, RedisCommand.LMOVE, sourceKey, destinationKey, whereFrom == ListSide.Left ? "Left" : "right", whereTo == ListSide.Left ? "Left" : "right"); |
There was a problem hiding this comment.
We should be consistent in Left vs right here :)
| Skip.IfMissingFeature(conn, nameof(RedisFeatures.PushMultiple), f => f.PushMultiple); | ||
| var db = conn.GetDatabase(); | ||
| RedisKey key = "testlist"; | ||
| RedisKey key = Me(); |
There was a problem hiding this comment.
Thanks for these fixes btw!
3 participants
https://redis.io/commands/lmove/