Skip to content

Support the ZMSCORE command.#2082

Merged
NickCraver merged 8 commits intoStackExchange:mainfrom
ttingen:zmscore
Apr 14, 2022
Merged

Support the ZMSCORE command.#2082
NickCraver merged 8 commits intoStackExchange:mainfrom
ttingen:zmscore

Conversation

@ttingen
Copy link
Contributor

@ttingen ttingen commented Apr 12, 2022

NickCraver
NickCraver requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up doc tweaks for ease there, just a few requests on the processor and tests (happy to push to branch if easier and you're slammed). Thanks for this!!

@ttingen
Copy link
Contributor Author

ttingen commented Apr 12, 2022

@NickCraver all done with the requested changes. Let me know if there is anything else.

@NickCraver
Copy link
Collaborator

NickCraver commented Apr 12, 2022

@ttingen Made a few quick changes to normalization and naming (I see why keys in tests were confusing where above we did need 2 unique keys - sorry about that!) - will try to do a top-down review in a bit!

@NickCraver NickCraver requested a review from slorello89 April 12, 2022 13:35
NickCraver
NickCraver approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttingen I think current is good - thank you! I'd appreciate @slorello89 eyes here when time allows.

@NickCraver NickCraver mentioned this pull request Apr 12, 2022
Open
@NickCraver
Copy link
Collaborator

NickCraver commented Apr 14, 2022

@slorello89 @Avital-Fine Can one of y'all provide secondary eyes here please?

slorello89
slorello89 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow missed the request @NickCraver sorry about that! LGTM 👍

@NickCraver NickCraver merged commit cb571bd into StackExchange:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

@slorello89 slorello89 slorello89 approved these changes

Assignees

No one assigned

Labels

⚙️ area:API ⚙️ area:commands ➕ enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ttingen @NickCraver @slorello89