Support EXPIRETIME and PEXPIRETIME#2083
Merged
NickCraver merged 27 commits intoStackExchange:mainfrom Apr 16, 2022
Avital-Fine:expire
Merged
Support EXPIRETIME and PEXPIRETIME#2083NickCraver merged 27 commits intoStackExchange:mainfrom Avital-Fine:expire
NickCraver merged 27 commits intoStackExchange:mainfrom
Avital-Fine:expire
Conversation
NickCraver
reviewed
Apr 12, 2022
NickCraver
requested changes
Apr 13, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
I'm trying to grok the TTL bits and intent but tried to add initial thoughts on everything - this being an overload change is a bit more to consider!
Making diff a bit easier to parse here and simplifying a bit while I'm at it.
Collaborator
|
@Avital-Fine need a break for staring at this and a few doc tweaks, but think it's close with |
NickCraver
approved these changes
Apr 16, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
@slorello89 I think this is good but I've also been staring at and tweaking it a while, would appreciate an external set of eyes when time allows <3
Closed
NickCraver
pushed a commit
that referenced
this pull request
May 10, 2022
Continue #2083 Now when we can overload function - we can do it also to `KeyExpire` and `KeyExpireAsync`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the method returns TimeSpan and not a number like the redis server (similar to OBJECT IDLETIME), PEXPIRETIME has no difference from EXPIRETIME.
https://redis.io/commands/expiretime/
https://redis.io/commands/pexpiretime/
#2055