Fix hashslot calculation for XACK, XCLAIM and XPENDING#2085
Merged
NickCraver merged 3 commits intoStackExchange:mainfrom Apr 13, 2022
Merged
Fix hashslot calculation for XACK, XCLAIM and XPENDING#2085NickCraver merged 3 commits intoStackExchange:mainfrom
NickCraver merged 3 commits intoStackExchange:mainfrom
Conversation
…ands => fixes incorrect HashSlot calculation.
Contributor
Author
|
The commands XREADGROUP, XREAD, XGROUP and XINFO have the same problem. I have created issue #2086 for these commands as they couldn't be fixed by using an already existing MessageCommand. |
Avital-Fine
approved these changes
Apr 13, 2022
NickCraver
approved these changes
Apr 13, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Looking great - thanks for this and the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of XACK, XCLAIM and XPENDING uses a ComandValuesMessage. Due to this the GetHashSlot() method always returns -1.
Using these commands in a redis cluster environment will result in MOVED responses as the commands are send to incorrect endpoints.