Merged
Conversation
This allows for using new APIs introduced in net6.0. In order to enable building for net6.0, we also need to revert the thread pool changes in StackExchange#1939 and StackExchange#1950. This was already effectively reverted in StackExchange#1992 by not building for net6.0. Now that we are building for net6.0 again, these if-defs need to be removed.
Collaborator
|
FWIW I'm good with dropping |
Closed
NickCraver
approved these changes
Jul 1, 2023
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Looking good - thanks for the tweaks!
|
Why not drop .NET Core 3.1 as well while at it? |
|
IMHO, dropping a target framework is a kind of change that warrants bumping a minor version (at least). |
Collaborator
|
@0xfeeddeadbeef because .NET Core 3.1 is newer and was an LTS which many more people are on for the long-term. If we're dropping an LTS, I'd agree with a minor version bump. For a non-LTS over a year past EOL I'm a lot less concerned :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for using new APIs introduced in net6.0.
In order to enable building for net6.0, we also need to revert the thread pool changes in #1939 and #1950. This was already effectively reverted in #1992 by not building for net6.0. Now that we are building for net6.0 again, these if-defs need to be removed.
Questions:
net5.0be removed? It has been end-of-life for over a year. I left it in, for now. It can be removed in the future, if we think it should be removed.cc @NickCraver @mgravell