add support for parsing and formatting unix domain sockets #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
requested changes
Nov 24, 2020
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
LGTM functionally, but suggested some quick tweaks to make cleanup super easy in a follow-up as .NET ships some upcoming bits.
| <SignAssembly>true</SignAssembly> | ||
| <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> | ||
| <DefineConstants Condition="'$(TargetFramework)' != 'net461'">$(DefineConstants);VECTOR_SAFE</DefineConstants> | ||
| <DefineConstants Condition="'$(TargetFramework)' != 'net461' and '$(TargetFramework)' != 'net472' and '$(TargetFramework)' != 'netstandard2.0'">$(DefineConstants);UNIX_SOCKET</DefineConstants> |
Collaborator
There was a problem hiding this comment.
Recommend we define NETCOREAPP3_1_OR_GREATER here, which is landing in a future .NET 5.0 SDK (servicing release) we can remove: https://github.com/dotnet/designs/pull/164/files. This let's us cleanup nicely later.
| case IPEndPoint ip: | ||
| if (ip.Port == 0) return ip.Address.ToString(); | ||
| return ip.Address + ":" + Format.ToString(ip.Port); | ||
| #if UNIX_SOCKET |
Collaborator
There was a problem hiding this comment.
Suggest:
Suggested change
| #if UNIX_SOCKET | |
| #if NETCOREAPP3_1_OR_GREATER |
| { | ||
| if (addressWithPort.Length == 1) return null; | ||
|
|
||
| #if UNIX_SOCKET |
Collaborator
There was a problem hiding this comment.
Suggested change
| #if UNIX_SOCKET | |
| #if NETCOREAPP3_1_OR_GREATER |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!in the configuration string, i.e.!/fooconnects to/fooover a unix domain socket(the actual work to connect via unix domain sockets has worked for a long time -
Socketdeals with it)