.Net Core RC2 upgrades to for a 1.604-alpha release #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RC2 project.json format and references - NuGet.config added since we're on one feed now - Unit tests minimally running in core - lots of work left here - Bumps to netstandard1.5 for BufferedStream, but we have net40, net45, and net46 builds already so this should be low impact. - AuthenticateAsClient() (synchronous) is no longer in .Net Core, Async version must be used there now. - Version bump to 1.604-* (alpha suffix is in via dotnet pack now) - To pack: dotnet pack StackExchange.Redis -o .nupkg -c Release --version-suffix alpha dotnet pack StackExchange.Redis.StrongName -o .nupkg -c Release --version-suffix alpha
| Action<Task> nonTrivial = delegate | ||
| { | ||
| #if !DNXCORE50 | ||
| #if !CORE_CLR |
There was a problem hiding this comment.
Why not just use the loop and SpinWait.SpinOnce()? I think it's netstd1.3, so should be available everywhere.
There was a problem hiding this comment.
@NickCraver I see -- yeah, don't worry about it. If what you have works no point in messing around unnecessarily.
|
No showstoppers found - proceeding with an alpha. |
|
I just pushed
Please let me know if you see any issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and net46 builds already so this should be low impact.
version must be used there now.
1.604-*(alpha suffix is in via dotnet pack now)