Skip to content

Conversation

@giamir
Copy link
Contributor

@giamir giamir commented Oct 29, 2025

SPARK-62

Figma

Here is what changed:

  • Stacks Classic: Updated the activity indicator component to the new visual language (default 16x16). Introduced .s-activity-indicator__sm variant (10x10). (docs)
  • Stacks Svelte: Added new ActivityIndicator component. (storybook)

Note 1: please ignore for now the activity indicator on the avatar not being rendered correctly. It will be sorted in the avatar PR that is coming right after this one.
Screenshot 2025-10-29 at 15 54 19

Note 2: Topbar screenshots are failing because they are using activity indicators which have changed slightly (10x10 instead of 12x12)

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: cfd00d4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit cfd00d4
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/690398ddbf07e3000915b355
😎 Deploy Preview https://deploy-preview-2027--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit cfd00d4
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/690398dd0c520c0008cb6882
😎 Deploy Preview https://deploy-preview-2027--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here except the whole vertical text alignment issue you mentioned. I made a suggestion to use inline-flex which will give us a better balance (not perfect but hopefully acceptable). Looks like this is what some other libraries (MUI, Ant Design) handle it as well.

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok don't hate me but... seeing this in the browser vs figma (using a different system font as well) makes them look extra small. I think we re-used the old component that was in Figma and updated the colors but that didn't match the sizing that was in stacks. Looking from old to new it does look to tight/small.

I've bump up the sizing on the dot for both:

  • large size with characters would be 16x16 (roughly the same size as current)
  • small size would be 10x10 (in between what we have today and what I had originally proposed)

Both updated in Figma as well.

@giamir
Copy link
Contributor Author

giamir commented Oct 30, 2025

Ok don't hate me but... seeing this in the browser vs figma (using a different system font as well) makes them look extra small. I think we re-used the old component that was in Figma and updated the colors but that didn't match the sizing that was in stacks. Looking from old to new it does look to tight/small.

I've bump up the sizing on the dot for both:

large size with characters would be 16x16 (roughly the same size as current)
small size would be 10x10 (in between what we have today and what I had originally proposed)
Both updated in Figma as well.

@CGuindon I have applied your requested changes here. Can you give it another review? Thanks
7c4c81b

Docs
Storybook

@giamir giamir requested review from CGuindon and dancormier October 30, 2025 08:21
Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it looks much nicer at 16px. I locally merged in the design system typography changes and all the sizes stayed consistent while seeing the font size jump a pixel.

Screenshots

Pre-type changes

20251030-103806

Post-type changes

20251030-103827

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that stands out for me is the different padding I'm seeing in the types. It looks like the icon with a numbered activity indicator has more padding than without an icon?

The one on the left is correct (less padding on the sides).
Screenshot 2025-10-30 at 7 53 47 AM

@giamir
Copy link
Contributor Author

giamir commented Oct 30, 2025

@dancormier Merging this as agreed in our conversation early. If you have a minute feel free to play around with the indicator on the notification icon. Thanks a lot ❤️

@giamir giamir merged commit 4bd5612 into beta Oct 30, 2025
18 checks passed
@giamir giamir deleted the SPARK-62/activity-indicator branch October 30, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants