Implement DS record support for ClouDNS#1018
Merged
tlimoncelli merged 21 commits intoDNSControl:masterfrom Jan 22, 2021
Merged
Conversation
Add PTR support for ClouDNS
Contributor
Author
|
@tlimoncelli I tested the DS record for ClouDNS, It's working. I am waiting for your reply |
tlimoncelli
suggested changes
Jan 20, 2021
Contributor
|
Perhaps wait with the review. I've just committed some changes which @jamaltebi will test.
|
primitive rate limit and fix order of NS/DS-entries
codefixes
Contributor
Yes. But I did not yet get around to test if ClouDNS sends 429 or another status code ... |
Contributor
|
Yes. But I did not yet get around to test if ClouDNS sends 429 or another
status code ...
To be clear: the current solution is sufficient for now.
… |
Contributor
|
Thank you. Just to be sure - the branch / pull request should be ready for merge from our side. If you need anything more, let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClouDNS does supprt DS Record ( DS record can be add just for subdomain nor for root domain).
==> Answer: No, you can't. First and foremost, in order for you to be able to add a DS record for your subdomain, the delegation part of your subdomain must be in action. In simple words, the relevant NS records for your subdomain, the "delegators" so to say, must be added first. And to add the NS records, there must be no other records for that particular hostname.