NEW PROVIDER: Oracle Cloud#1021
NEW PROVIDER: Oracle Cloud#1021tlimoncelli merged 7 commits intoDNSControl:masterfrom kallsyms:master
Conversation
tlimoncelli
left a comment
There was a problem hiding this comment.
Looks great so far! I will have a closer look in a few days.
don't worry about adding DS in a separate PR. It's common to do that. Get the base working well then augment it.
tlimoncelli
left a comment
There was a problem hiding this comment.
Great work! There is very close to being ready to merge. I just had a few small changes.
By the way... in intergration_test.go, Oracle isn't running the pager601 tests. Since the API is slow, and since page size is 100, this test isn't needed. That said, it might be useful to run this test just once to verify functionality (but don't include it in the PR).
|
Changes addressed! Just tried the |
tlimoncelli
left a comment
There was a problem hiding this comment.
Looks great! Super minor change and we're all done!
(thanks for running the pager601 test. Yeah, timeouts are expected. At least it worked up until the timeout!)
|
Done! |
This PR introduces a provider for Oracle Cloud DNS.
OCI DNS API Docs: https://docs.oracle.com/en-us/iaas/api/#/en/dns/20180115/
Few miscellaneous notes from development:
Addresses #419.