New provider and new registrar: hosting.de by juliusrickert · Pull Request #1041 · DNSControl/dnscontrol

juliusrickert · 2021-02-05T17:11:56Z

No description provided.

tlimoncelli

Great so far! Some minor feedback.

juliusrickert · 2021-02-06T12:41:51Z

http.net is connected deeply to hosting.de ("their" consumer-facing business) and they share the same API.

I could add a provider for hosting.de very easily. How should I go about doing this without copying the code?

…p.net

tlimoncelli · 2021-02-21T19:48:42Z

hosting.de + http.net: I don't have a preference for 1 or 2 providers. Is it likely that they would diverge? If not, one provider is better.

juliusrickert · 2021-02-22T10:19:39Z

I think it is unlikely for them to diverge regarding the DNS and domain APIs.

I am thinking about letting the user specify the API endpoint for maximum flexibility (e.g. ability to use it with their demo systems) and maybe optionally set a different set of default nameservers (honestly not that important as they are the same servers with the same IP addresses).

tlimoncelli · 2021-02-22T14:57:37Z

Allowing the user to specify the API endpoint sounds like the best solution. Many providers permit one to specify the endpoint to change to a testing environment, etc. (Namecheap, NameDotCom, PowerDNS are examples.)

juliusrickert · 2021-02-22T16:22:52Z

Done. Extended the docs as well.

membero · 2021-03-01T13:30:32Z

Hello @tlimoncelli,

I am from hosting.de / http.net. We gladly support this plugin. I have talked to @juliusrickert and he will rename/relabel it to hosting.de. It would be great if you could merge this plugin after renaming. We will take over support and further development after that.

- Fix EnsureDomainExists - GetNameservers read from NS Records

tlimoncelli

Hi there!

I'm super excited to hear you'll be supporting this!

I made a few small suggestions about the code. HTH

tlimoncelli · 2021-03-01T16:52:20Z

 providers/hedns @rblenkinsopp
 providers/hetzner @das7pad
 providers/hexonet @papakai
+providers/httpnet @juliusrickert


Change to providers/hostingde ?

tlimoncelli · 2021-03-01T16:53:22Z

 - Hetzner
 - HEXONET
 - Hurricane Electric DNS
+ - http.net


Change to - hosting.de / http.net ?

tlimoncelli · 2021-03-01T16:54:17Z

 * `HEDNS` @rblenkinsopp
 * `HETZNER` @das7pad
 * `HEXONET` @papakai
+* `HTTPNET` @juliusrickert


s/HTTPNET/HOSTINGDE/

Contributor Support from hosting.de

membero · 2021-03-01T17:07:16Z

Thanks! I have updated these lines.

tlimoncelli · 2021-03-04T01:27:03Z

+
+**If you want to use this provider with http.net or a demo system you need to provide a custom `baseURL`.**
+
+* http.net: `https://partner.http.net`


Suggestion: Add a bullet:

Hosting.de: default

tlimoncelli · 2021-03-04T01:28:28Z

+jsId: hostingde
+---
+# hosting.de Provider
+


Suggestion: Add a paragraph saying that this provider suports the API used by Hosting.de and http.net, which both use the same API. (or whatever)

I do not think that this is neccessary. http.net only provides registration services for bigger companies. Also http.net is mentioned later in the documentation.

tlimoncelli · 2021-03-04T01:29:36Z

+func (hp *hostingdeProvider) getDomainConfig(domain string) (*domainConfig, error) {
+	zc, err := hp.getZoneConfig(domain)
+	if err != nil {
+		return nil, fmt.Errorf("error getting zone config: %v", err)


Use %w instead of %v

Done. I have replaced all of them.

tlimoncelli · 2021-03-04T01:30:10Z

+
+	resp, err := hp.get("domain", "domainsFind", params)
+	if err != nil {
+		return nil, fmt.Errorf("error getting domain info: %v", err)


Use %w instead of %v

tlimoncelli · 2021-03-04T01:30:18Z

+
+	domainConf := []*domainConfig{}
+	if err := json.Unmarshal(resp.Data, &domainConf); err != nil {
+		return nil, fmt.Errorf("error parsing response: %v", err)


Use %w instead of %v

tlimoncelli · 2021-03-04T01:32:16Z

+
+	zc := []*zoneConfig{}
+	if err := json.Unmarshal(resp.Data, &zc); err != nil {
+		return nil, fmt.Errorf("could not parse response: %v", err)


Use %w instead of %v

tlimoncelli · 2021-03-04T01:35:25Z

+		// Nothing special.
+	case "MX":
+		record.Priority = rc.MxPreference
+		record.Content = rc.Target


Rather than rc.Target, please use rc.GetTargetFrield()

For TXT records, please use .TxtStrings (which may require special handling, since it is a []string)

TXT handling will change in a few days. It might break this code. See #1063

Done. Once you merge the tlim_target_and_txt branch I will create an auditrecords.go.

replaced %v with %w for errors special handling for txt records using .TxtStrings

fixed Trim of last dot

tlimoncelli · 2021-03-07T18:22:19Z

Please rebase (i.e. get merge master) and go generate

…rol#1063)

tlimoncelli · 2021-03-09T00:26:11Z

Yay! Another new provider! Thank you for contributing this!

* Add http.net provider * Rename httpnetProvider * Add SSHFP capability * Add paging for records * Sort documentation notes alphabetically * Add custom base URL * Extend documentation for custom base URL * - renamed to hosting.de - Fix EnsureDomainExists - GetNameservers read from NS Records * Replaced http.net with hosting.de Contributor Support from hosting.de * baseURL for hosting.de in documentation replaced %v with %w for errors special handling for txt records using .TxtStrings * removed last references to rc.Target fixed Trim of last dot * Re-engineer TXT records for simplicity and better compliance (#1063) Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com> Co-authored-by: Oliver Dick <o.dick@hosting.de> Co-authored-by: Oliver Dick <31733320+membero@users.noreply.github.com>

Add http.net provider

f143582

tlimoncelli reviewed Feb 5, 2021

View reviewed changes

Comment thread providers/httpnet/api.go Outdated

Comment thread providers/httpnet/api.go Outdated

Comment thread providers/httpnet/httpnetProvider.go

juliusrickert added 2 commits February 6, 2021 13:45

Rename httpnetProvider

965b9df

Add SSHFP capability

bb33f78

juliusrickert force-pushed the http.net branch from 3d78e9c to bb33f78 Compare February 6, 2021 12:47

juliusrickert and others added 4 commits February 6, 2021 15:27

Add paging for records

3a28ef7

Sort documentation notes alphabetically

de9e861

Merge branch 'master' of github.com:StackExchange/dnscontrol into htt…

a0a716f

…p.net

Merge branch 'master' into http.net

3e30214

juliusrickert added 2 commits February 22, 2021 17:02

Add custom base URL

d12fc24

Extend documentation for custom base URL

571b7b6

membero and others added 2 commits March 1, 2021 17:00

- renamed to hosting.de

59e0bd7

- Fix EnsureDomainExists - GetNameservers read from NS Records

Merge branch 'master' into http.net

b6a1b13

tlimoncelli changed the title ~~New provider and new registrar: http.net~~ New provider and new registrar: hosting.de Mar 1, 2021

tlimoncelli reviewed Mar 1, 2021

View reviewed changes

Replaced http.net with hosting.de

4600658

Contributor Support from hosting.de

tlimoncelli added 3 commits March 1, 2021 19:55

Merge branch 'master' into http.net

9989963

Merge branch 'master' into http.net

05939bf

Merge branch 'master' into http.net

8d01894

tlimoncelli reviewed Mar 4, 2021

View reviewed changes

membero and others added 3 commits March 4, 2021 13:46

baseURL for hosting.de in documentation

279f551

replaced %v with %w for errors special handling for txt records using .TxtStrings

Merge branch 'master' into http.net

0cca164

removed last references to rc.Target

e1aaccc

fixed Trim of last dot

membero and others added 5 commits March 8, 2021 11:44

Merge branch 'master' into http.net

3c2797e

Re-engineer TXT records for simplicity and better compliance (DNSCont…

0cffb17

…rol#1063)

Merge branch 'master' into http.net

1d1edcb

Merge branch 'master' into http.net

7f57d81

Merge branch 'master' into http.net

c0809ed

tlimoncelli merged commit c883c1a into DNSControl:master Mar 9, 2021

membero deleted the http.net branch March 9, 2021 08:50


		If you want to use this provider with http.net or a demo system you need to provide a custom `baseURL`.

		* http.net: `https://partner.http.net`

Conversation

juliusrickert commented Feb 5, 2021

Uh oh!

tlimoncelli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusrickert commented Feb 6, 2021

Uh oh!

tlimoncelli commented Feb 21, 2021

Uh oh!

juliusrickert commented Feb 22, 2021

Uh oh!

tlimoncelli commented Feb 22, 2021

Uh oh!

juliusrickert commented Feb 22, 2021

Uh oh!

membero commented Mar 1, 2021

Uh oh!

tlimoncelli left a comment

Choose a reason for hiding this comment

Uh oh!

tlimoncelli Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

membero commented Mar 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

membero Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tlimoncelli commented Mar 7, 2021

Uh oh!

tlimoncelli commented Mar 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

tlimoncelli Mar 1, 2021 •

edited

Loading

membero Mar 4, 2021 •

edited

Loading