Fetch ClouDNS allowed TTL values from API. #1078#1102
Merged
Conversation
riku22
changed the title
tlimoncelli
reviewed
Mar 22, 2021
| return fmt.Errorf("failed fetching available TTL values list from ClouDNS: %s", err) | ||
| } | ||
|
|
||
| json.Unmarshal(bodyString, &allowedTTLValues) |
Contributor
There was a problem hiding this comment.
Return err result instead of nil?
| } | ||
|
|
||
| func (c *cloudnsProvider) fetchAvailableTTLValues(domain string) error { | ||
| allowedTTLValues = nil |
Contributor
There was a problem hiding this comment.
Is fetchAvailableTTLValues going to make this API call more than once? Would it be sufficient to call it only if needed?
|
|
||
| type recordResponse map[string]domainRecord | ||
|
|
||
| var allowedTTLValues = []uint32{ |
Contributor
There was a problem hiding this comment.
Using the API is good. It is better than a constant.
Is the API returning any values that are not on this list? For backwards compatibility it would be good to know.
Contributor
Author
|
Hello.
|
Contributor
|
hello! "1. The API must be called for each zone." Interesting! Please add a comment in the code. Other people will find that useful. |
Contributor
Author
|
Added a comment. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch ClouDNS allowed TTL values from API.
Fix the problem of # 1078.