ns1: Add support for diff2#1858
Merged
Merged
Conversation
ugly, but good enough for now
... while there, reorder code a bit
Contributor
Author
|
Hey @tlimoncelli, this should be all that's needed to add diff2 support to the ns1 provider :) |
tlimoncelli
reviewed
Dec 18, 2022
Contributor
tlimoncelli
left a comment
tlimoncelli
left a comment
There was a problem hiding this comment.
Looks good so far. One request: When we delete the "if diff2.EnabledDiff2" and legacy code, it would be nice if the remaining code didn't need to change indenting. That way "git blame" will show you as the author of these lines.
tlimoncelli
reviewed
Dec 19, 2022
Remove a conditional by making diff2 the default, keeping the conditional for the legacy diff code path.
Contributor
|
Looks great! Thanks! |
tlimoncelli
added a commit
that referenced
this pull request
Jan 11, 2023
Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds proper support for conditionally enabling diff2 in the NS1 provider.
While there, some code was shuffled around:
Relates to #1854