Adapt OVH provider to Diff2#1861
Merged
Merged
Conversation
OVH API deals with records so the new Diff2 based implementations is not very different than the actual Diff1 one.
masterzen
force-pushed
the
masterzen/ovh-diff2
branch
from
900d748 to
3c292dc
Compare
Contributor
|
Excellent! I like how you split out the diff1 vs diff2 code. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Diff2 (cf #1854) for the OVH provider.
OVH API deals with records so the new Diff2 based implementations is not very different than the actual Diff1 one.
Integration tests pass in both diff1 and diff2 modes.