Skip to content

Add missing MD5 support#1866

Merged
tlimoncelli merged 2 commits into
DNSControl:masterfrom
hm-edu:md5axfr
Dec 31, 2022
Merged

Add missing MD5 support#1866
tlimoncelli merged 2 commits into
DNSControl:masterfrom
hm-edu:md5axfr

Conversation

@fritterhoff
Copy link
Copy Markdown
Contributor

Go officially does not support MD5 for TSIG. Sadly we have a provider that requires the usage of MD5. This PR adds the missing support ;-)

@tlimoncelli
Copy link
Copy Markdown
Contributor

Looks good! Could you add something to the docs (docs/_providers/axfrddns.md) explaining what is added, etc. It should also note that this may be removed once the provider drops md5 support. (Can you include the name of the provider?)

@fritterhoff
Copy link
Copy Markdown
Contributor Author

Yeah sure. The provider is the Leibniz Supercomputing Centre (LRZ) located in Munich.

@tlimoncelli
Copy link
Copy Markdown
Contributor

Looks good! Please rebase and I'll merge.

@fritterhoff
Copy link
Copy Markdown
Contributor Author

Done :)

@tlimoncelli tlimoncelli merged commit 4cf4d34 into DNSControl:master Dec 31, 2022
@fritterhoff fritterhoff deleted the md5axfr branch December 31, 2022 12:04
tlimoncelli pushed a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants