Skip to content

DNSIMPLE: Adopt diff2 in compatibility mode#1878

Merged
tlimoncelli merged 3 commits into
masterfrom
tlim_diff2_dnsimple
Jan 3, 2023
Merged

DNSIMPLE: Adopt diff2 in compatibility mode#1878
tlimoncelli merged 3 commits into
masterfrom
tlim_diff2_dnsimple

Conversation

@tlimoncelli
Copy link
Copy Markdown
Contributor

@tlimoncelli tlimoncelli commented Dec 31, 2022

Hi @onlyhavecans:

In reference to replacing pkg/diff with the new pkg/diff2 (#1854)

I've introduced a compatibility mode to pkg/diff2 to make it easier for providers to adopt the new system. If you do a diff with "hide whitespace", you'll see the changes are minimal.

I've taken the liberty of providing this PR as a starting point.

Please run the integration tests and let me know the result. (If you're getting this, I probably don't have access to an account on this provider)

Please run:

    go test -v -verbose -provider DNSIMPLE

and

    go test -v -verbose -provider DNSIMPLE -diff2

They should both complete with no failures. Please fix any failures or loop me in for help.

If you are interested in porting to the new pkg/diff2/By*() functions, I'd be glad to accept a PR. However using the compatibility mode is sufficient if all tests pass.

Thanks and happy new years!!!

Tom
@tlimoncelli

@tlimoncelli tlimoncelli mentioned this pull request Dec 31, 2022
39 tasks
@onlyhavecans
Copy link
Copy Markdown
Contributor

Happy New Year Tom!

I ran the tests, and they all pass. I will work on getting this moved to ByRecord() soon™. I have a busy few weeks ahead of me so it's "soon™", not just "soon"

@tlimoncelli
Copy link
Copy Markdown
Contributor Author

Great! I'll merge this and await the rewrite in another PR. No rush. soon™ is good!

@tlimoncelli tlimoncelli merged commit a498679 into master Jan 3, 2023
@tlimoncelli tlimoncelli deleted the tlim_diff2_dnsimple branch January 3, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants