HEDNS: Add full Diff2 support#1915
Merged
Merged
Conversation
Contributor
|
Excellent! Thank you so much! (and congrats on a merge with no comments!) |
Contributor
Author
|
Did you mean to close this rather than merge? (No worries if you did but, it wasn't what I was expecting based on the comment :) ) |
Contributor
|
Oops! I totally meant to merge. |
Contributor
|
My apologies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds full support for Diff2 rather than using the compatibility mode, as well as some refactoring to reduce code reuse.
It has been tested in both Diff1 and Diff2 modes and all tests pass.