Skip to content

CHORE: linting#2176

Merged
TomOnTime merged 2 commits into
masterfrom
tlim_golint
Mar 15, 2023
Merged

CHORE: linting#2176
TomOnTime merged 2 commits into
masterfrom
tlim_golint

Conversation

@TomOnTime
Copy link
Copy Markdown
Collaborator

Fixing these...

build/generate/functionTypes.go:47:9: if block ends with a return statement, so drop this else and outdent its block
build/generate/functionTypes.go:48:30: error strings should not be capitalized or end with punctuation or a newline
pkg/diff2/compareconfig.go:46:6: exported type ComparableFunc should have comment or be unexported
pkg/diff2/compareconfig.go:48:6: exported type CompareConfig should have comment or be unexported
pkg/diff2/compareconfig.go:91:1: exported function NewCompareConfig should have comment or be unexported
pkg/diff2/compareconfig.go:111:1: exported method CompareConfig.VerifyCNAMEAssertions should have comment or be unexported
pkg/diff2/diff2.go:16:6: exported type Verb should have comment or be unexported
pkg/diff2/diff2.go:20:2: exported const CREATE should have comment (or a comment on this block) or be unexported
pkg/diff2/diff2.go:26:6: exported type ChangeList should have comment or be unexported
pkg/diff2/diff2.go:28:6: exported type Change should have comment or be unexported

@TomOnTime
Copy link
Copy Markdown
Collaborator Author

CC @systemcrash for visibility (build/generate/functionTypes.go)

@TomOnTime TomOnTime changed the title CORE: linting CHORE: linting Mar 15, 2023
@TomOnTime TomOnTime merged commit 81054e7 into master Mar 15, 2023
@TomOnTime TomOnTime deleted the tlim_golint branch March 15, 2023 22:35
@systemcrash
Copy link
Copy Markdown
Contributor

I suppose that's another way of doing it 😄

@systemcrash
Copy link
Copy Markdown
Contributor

Question: is it plausible that len(delimiterIndices) can be greater than 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants