Skip to content

CLOUDFLAREAPI: Add NAPTR record support#2548

Merged
tlimoncelli merged 1 commit into
DNSControl:masterfrom
asn-iac:feature/cloudflare-naptr
Sep 7, 2023
Merged

CLOUDFLAREAPI: Add NAPTR record support#2548
tlimoncelli merged 1 commit into
DNSControl:masterfrom
asn-iac:feature/cloudflare-naptr

Conversation

@asn-iac
Copy link
Copy Markdown
Contributor

@asn-iac asn-iac commented Sep 5, 2023

Add support for NAPTR records to cloudflare provider.
(#2547)

@asn-iac
Copy link
Copy Markdown
Contributor Author

asn-iac commented Sep 5, 2023

I added a new type to handle encoding/decoding of the data object for the NAPTR record to avoid type conflict with the existing "Flags" field in the generic "cfRecData" type. Please let me know if it's preferred to handle in a different way. TIA!

@tlimoncelli
Copy link
Copy Markdown
Contributor

I added a new type to handle encoding/decoding of the data object for the NAPTR record to avoid type conflict with the existing "Flags" field in the generic "cfRecData" type. Please let me know if it's preferred to handle in a different way. TIA!

Looks good to me!

@tlimoncelli
Copy link
Copy Markdown
Contributor

This looks good. I'll merge it soon.

I'm curious: What do you use NAPTR for? I'm curious now popular this feature is. (I added the original NAPTR support but I haven't used it in a year or more)

@tlimoncelli tlimoncelli merged commit af91e37 into DNSControl:master Sep 7, 2023
@asn-iac
Copy link
Copy Markdown
Contributor Author

asn-iac commented Sep 7, 2023

This looks good. I'll merge it soon.

I'm curious: What do you use NAPTR for? I'm curious now popular this feature is. (I added the original NAPTR support but I haven't used it in a year or more)

@tlimoncelli I'd actually not encountered this record type previously and had to go look at the rfc... it came up in a domain portfolio we have in cloudflare that I'm finally pulling into our dnscontrol ci/cd pipeline. The team using this record develops a telephony-based app, so it wasn't too surprising in the end. Most of the other domains we've managed over the years are more web app focused

Thanks again for all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants