NEW RECORD TYPE: DHCID#2557
Merged
Merged
Conversation
Contributor
Author
|
@fritterhoff Since this was breaking the builds, and since I had a few extra moments, I've fixed the major issue in this PR. |
Contributor
Author
Contributor
Author
|
@fritterhoff Ah! I think I got it! We'll know for sure when https://github.com/StackExchange/dnscontrol/actions/runs/6190265118/job/16806973100?pr=2557 completes. |
Contributor
Author
|
@fritterhoff I think I fixed it all. Can you take a look? (Perhaps test it with axfrddns to be sure. I don't have have an automated test for that provider) |
Contributor
|
LGTM! Sorry for the extra work... |
Contributor
Author
|
No worries. I blame git :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.