fix(ENG-253): disable connect button while connector is loading#151
Merged
adefreitas merged 1 commit intoStackOneHQ:mainfrom May 6, 2026
Merged
Conversation
Prevents users from triggering handleConnect against incomplete connectorData by disabling the Connect button (and showing a spinner) while the connector config query is in flight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the integration picker footer behavior to prevent users from initiating a connection while integration/connector data is still loading, by threading an isLoading flag down into the footer and using it to disable actions and show a spinner.
Changes:
- Passes
isLoadingfromuseIntegrationPickerthroughIntegrationPickerintoCardFooter. - Disables the Back button while loading.
- Disables the Connect button while loading and shows the button’s loading spinner during that time.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules/integration-picker/IntegrationPicker.tsx | Threads isLoading into CardFooter so the footer can reflect loading state. |
| src/modules/integration-picker/components/cardFooter.tsx | Adds isLoading prop; disables Back/Connect while loading and shows loading spinner on Connect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleConnectagainst incompleteconnectorData.isLoadingstate fromuseIntegrationPicker(which already combines hub/connector/account loading) throughIntegrationPickerintoCardFooter.Test plan
🤖 Generated with Claude Code