Skip to content

fix(ENG-10961): fix styling issues#25

Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:ENG-10961/fix-styling-issues-in-hub
Nov 6, 2025
Merged

fix(ENG-10961): fix styling issues#25
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:ENG-10961/fix-styling-issues-in-hub

Conversation

@adefreitas
Copy link
Copy Markdown
Collaborator

@adefreitas adefreitas commented Nov 6, 2025

Screen.Recording.2025-11-06.at.16.09.41.mov
Screen.Recording.2025-11-06.at.16.10.47.mov

Summary by cubic

Fixes Hub integration picker styling to improve header layout, scrolling, and footer behavior. Addresses ENG-10961 by polishing search/category UX, form overflow, and title sizing.

  • Bug Fixes

    • Moved search and category pills into a new IntegrationListHeader shown as the Card title; zero header padding and enabled glass footer.
    • Hoisted search/category state to IntegrationPicker and passed to views for stable filtering.
    • Added horizontally scrollable category pills with hidden scrollbar (hide-scrollbar) to prevent overflow.
    • Made the form area scrollable (overflow: auto) and refined error text spacing.
    • Reduced logo/title sizes and used a smaller “Connection guide” button for better balance.
    • Added showFooterLinks to optionally hide footer links when no actions are shown; wired through Hub, StackOneHub, and IntegrationPicker (default true).
  • Dependencies

    • @stackone/malachite: 0.22.0 → 0.22.1.

Written for commit 795ae2f. Summary will update automatically on new commits.

@adefreitas adefreitas requested review from a team and Copilot November 6, 2025 16:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the integration picker component to separate state management and UI concerns, adds support for a configurable footer, and updates the UI design with improved styling and layout.

  • Lifts search and category filter state from IntegrationList to IntegrationPicker parent component
  • Splits IntegrationList into IntegrationListHeader and IntegrationList components for better separation of concerns
  • Adds showFooterLinks prop to conditionally render footer links throughout the component hierarchy

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
IntegrationListView.tsx Passes new search and category props, re-exports IntegrationListHeader
cardTitle.tsx Reduces logo and button sizes for visual refinement
cardFooter.tsx Adds showFooterLinks prop to conditionally render footer links
IntegrationPickerContent.tsx Forwards search and category props to child components
IntegrationList.tsx Splits into header and list components, removes local state management
IntegrationFields.tsx Updates padding and formatting, removes nested Spacer wrapper
IntegrationPicker.tsx Adds state management for search/category, implements new header structure
StackOneHub.tsx Passes through showFooterLinks prop
Hub.tsx Passes through showFooterLinks prop
package.json Updates @stackone/malachite dependency to 0.22.1
package-lock.json Updates malachite lockfile entry
dev/main.css Adds hide-scrollbar CSS class for webkit browsers
Comments suppressed due to low confidence (2)

src/StackOneHub.tsx:17

  • Unused import CsvImporter.
import { CsvImporter } from './modules/csv-importer.tsx/CsvImporter';

src/StackOneHub.tsx:18

  • Unused import IntegrationPicker.
import { IntegrationPicker } from './modules/integration-picker/IntegrationPicker';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/integration-picker/components/IntegrationList.tsx Outdated
Comment thread src/modules/integration-picker/components/cardTitle.tsx
Comment thread src/modules/integration-picker/IntegrationPicker.tsx
Comment thread src/modules/integration-picker/IntegrationPicker.tsx Outdated
Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated
@adefreitas adefreitas merged commit 938eafe into StackOneHQ:main Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants