fix(ENG-10975): send provider as parameter#32
Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom Nov 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes how the provider filter is sent to the hub API, switching from a custom header (x-hub-provider) to a query parameter (?provider=...). This aligns with more standard REST API practices.
Key changes:
- Replaced header-based provider filtering with query parameter approach
- Removed the comment about adding provider header
- Modified URL construction to conditionally append the query parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adefreitas
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joeStackOne
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Send the provider as a query parameter in getHubData instead of a header so the hub connectors API returns the correct provider-specific data. Fixes ENG-10975 by making the dashboard open edit mode with pre-filled values instead of the new link account view.
Written for commit 6c78c0d. Summary will update automatically on new commits.