feat(ENG-11298): Pinning GitHub actions#68
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances security by pinning GitHub Actions to specific commit hashes instead of mutable version tags. This prevents potential supply chain attacks where action tags could be moved to malicious commits.
Key Changes:
- Replaced version tag references with commit SHA hashes across all workflow files
- Added inline comments to document the semantic versions corresponding to each commit hash
- Applied consistent pinning pattern to actions from multiple sources (amannn, googleapis, actions)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/semantic-pull-request.yml |
Pinned amannn/action-semantic-pull-request to commit hash for v5 |
.github/workflows/release-please.yml |
Pinned googleapis/release-please-action, actions/checkout, and actions/setup-node to specific commit hashes with version comments |
.github/workflows/node-ci.yml |
Pinned actions/checkout and actions/setup-node to the same commit hashes as in release-please workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v5 | ||
| - uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5 |
There was a problem hiding this comment.
[nitpick] The version comment for this action uses only the major version # v5, while other actions in this PR use more specific version tags (e.g., # v4.3.1, # v4.4.0). For consistency and better documentation, consider using a more specific version tag in the comment (e.g., # v5.0.0 or the specific v5.x.y version that this commit hash corresponds to).
| - uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5 | |
| - uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5.0.0 |
Summary by cubic
Pinned GitHub Actions to exact versions across CI workflows to improve security and reproducibility. Addresses ENG-11298 by enforcing version pinning in our pipelines.
Written for commit 433ef60. Summary will update automatically on new commits.