fix(ENG-11669): emit on success for oauth flows#86
Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom Dec 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the OAuth success handling to ensure the onSuccess callback is emitted consistently across all OAuth flow paths. The main change introduces a centralized handleSuccess callback that both sets the connection state and triggers the onSuccess callback, replacing multiple instances of direct state setting.
Key Changes:
- Introduced a
handleSuccesscallback that centralizes success handling logic - Changed the timing of
onSuccessemission in the non-OAuth flow from delayed (2 seconds) to immediate - Updated dependency arrays for affected
useCallbackhooks to includehandleSuccess
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joeStackOne
reviewed
Dec 17, 2025
| token={token} | ||
| baseUrl={apiUrl} | ||
| theme={theme} | ||
| onSuccess={() => { |
Contributor
There was a problem hiding this comment.
Is it intentional we're showing an alert instead of previously showing a log?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.