fix(ci): revert changes 2.0.5 ~ 2.0.7 #246
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts changes made in versions 2.0.5 through 2.0.7, restoring the CI/CD pipeline configuration and development environment setup to their previous state.
Key changes:
- Restored the
preinstallscript to enforce pnpm usage - Simplified the release workflow by removing intermediate pack step
- Removed explicit Node.js dependency from the Nix development shell
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Re-added preinstall script to enforce pnpm package manager |
| flake.nix | Removed nodejs_24 from development shell dependencies |
| .github/workflows/release.yaml | Simplified publishing by directly using pnpm publish instead of pack/publish sequence |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| in | ||
| { | ||
| devShells.default = pkgs.mkShell { | ||
| buildInputs = with pkgs; [ |
There was a problem hiding this comment.
Removing nodejs_24 from buildInputs while keeping pnpm_10 may cause issues, as pnpm requires Node.js to function. Either Node.js should be included explicitly or pnpm_10 should provide it as a dependency. Verify that pnpm_10 includes Node.js or re-add nodejs to the buildInputs.
| buildInputs = with pkgs; [ | |
| buildInputs = with pkgs; [ | |
| nodejs_24 |
| PACKAGE_TGZ=$(ls *.tgz | head -n 1) | ||
| echo "Publishing package: $PACKAGE_TGZ" | ||
| npm publish "$PACKAGE_TGZ" --access public | ||
| run: nix develop --command pnpm publish --provenance --no-git-checks --access public |
There was a problem hiding this comment.
The --no-git-checks flag bypasses important safety checks that verify the working directory is clean and the git tag matches the package version. This could lead to publishing packages with uncommitted changes or version mismatches. Consider removing this flag unless there is a specific reason to bypass these validations.
| run: nix develop --command pnpm publish --provenance --no-git-checks --access public | |
| run: nix develop --command pnpm publish --provenance --access public |
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This reverts commit 91909a2.
This reverts commit 91909a2.
Summary by cubic
Reverts the release pipeline changes from 2.0.5–2.0.7 to restore direct pnpm publish with provenance. Also tightens local tooling and simplifies the dev shell.
Written for commit e655535. Summary will update automatically on new commits.