Fix compatibility to Python 3 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I just came across a problem in this pack, when running with the new StackStorm 3.4. This change fixed it for me. Cheers Hannes
nmaludy
suggested changes
Mar 8, 2021
Contributor
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
@cyberkov Thanks for this fix! Can you please address these two final things:
- Add a Changelog entry here: https://github.com/StackStorm-Exchange/stackstorm-gitlab/blob/master/CHANGELOG.md
- Bump the
versionkey inpack.yamlto1.0.1: https://github.com/StackStorm-Exchange/stackstorm-gitlab/blob/master/pack.yaml#L6
Thanks!
Contributor
Author
|
Hi @nmaludy! Thanks for the review. I bumped the version but kept the changelog message high level. I guess no one is really that interested in such small changes :-) Best wishes |
nmaludy
approved these changes
Mar 9, 2021
Contributor
|
Thanks again for this fix! If you're interested in some StackStorm stickers via our Community Sticker Program , shoot me an email to nmaludy@gmail.com with your address and i'll get them sent over: https://github.com/StackStorm/discussions/wiki/Community-Sticker-Program |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I just came across a problem in this pack, when running with the new StackStorm 3.4. This change fixed it for me.
Cheers Hannes