Original sort was broken so fixed with a somewhat stabler sort #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The original sort looks ok but it acts very strange on the minor and patch values * The new sort is not as elegant but it works reliably. With the previous sort even with ["0.11.0", "0.11.1", "0.11.2", "0.11.2", "0.11.3", "0.11.4", "0.11.5", "0.11.6", "0.12.0", "0.12.1", "0.12.2", "0.8.3", "0.9.0", "0.9.0", "0.9.1", "0.9.2"] it would return 0.12.1 as highest. The new one does the right sort.
Contributor
Author
|
/cc jfryman If you have a better idea feel free to close PR and submit alternate fix. Best I could come up with :) |
Contributor
|
What a mess, right? Usually, I'd install a library and be done with it. Thanks for the fix. |
jfryman
added a commit
that referenced
this pull request
Aug 21, 2015
Original sort was broken so fixed with a somewhat stabler sort
Contributor
Author
|
Lol. I thought you would reject it as ugly ruby (btw, 1st time writing ruby) or write some short 1liner and do some magic :) Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous sort even with ["0.11.0", "0.11.1", "0.11.2", "0.11.2", "0.11.3", "0.11.4", "0.11.5", "0.11.6", "0.12.0", "0.12.1", "0.12.2", "0.8.3", "0.9.0", "0.9.0", "0.9.1", "0.9.2"]
it would return 0.12.1 as highest. The new one does the right sort.