Bump dependency versions #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
reviewed
Feb 23, 2019
Upstream released new version since creating this PR.
Contributor
Author
|
I've bumped all other dependencies, updated chart version and added an entry in the changelog. |
arm4b
approved these changes
Feb 26, 2019
Member
|
Per previous discussion, if new rabbitmq-ha Helm chart includes pod naming changes, then it needs more work TBD to verify if ST2 HA Helm templating works with those upstream changes well. |
2 tasks
arm4b
reviewed
Mar 6, 2019
| appVersion: 3.0dev | ||
| name: stackstorm-ha | ||
| version: 0.9.0 | ||
| version: 0.10.0 |
Member
There was a problem hiding this comment.
Ideally version needs to be bumped just before the release, as by the fact this is not yet 0.10.0.
Contributor
Author
There was a problem hiding this comment.
Oops, this slipped in there.. agreed.
Contributor
Author
|
Note that rabbitmq-ha |
Member
|
Useful info, It was a good opportunity to include that in code comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest versions of the
rabbitmq-haandmongodb-replicasetcharts.