Improve Prometheus setup, add injection scripts #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Reinartz <freinartz@google.com>
jkohen
suggested changes
Nov 19, 2018
| @@ -0,0 +1,23 @@ | |||
| #!/bin/sh | |||
Contributor
There was a problem hiding this comment.
Can you document how this should be invoked? What is the first argument ($1)?
Same for patch.sh
kube/README.md
Outdated
| * `KUBE_CLUSTER`: cluster name parameter for the sidecar | ||
| * `GCP_REGION`: GCP region parameter for the sidecar | ||
| * `GCP_PROJECT`: GCP project parameter for the sidecar | ||
| * `DATA_DIR`: data directory for the sidecar (`patch.sh` only) |
Contributor
There was a problem hiding this comment.
Doesn't patch.sh require reconfiguring Prometheus to use the /data directory and mount a named volume? If so, how about splitting this into its own section, and explaining how to set up Prometheus correctly?
If I understood correctly, Prometheus Operator already sets the data volume, right?
Contributor
Author
There was a problem hiding this comment.
In general, a Prometheus server would already have a mounted volume. So the DATA_DIR and DATA_VOLUME are just about attaching that volume to the sidecar as well and using the same data dir as Prometheus already does.
Signed-off-by: Fabian Reinartz <freinartz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkohen required some fiddling but this is working well AFAICS.
I removed the setup with an operator since that repo has very extensive documentation and customization options for setting up full k8s monitoring.
The full deployment now has a proper configuration rather than just trying to scrape all ports it can find. It can also scrape the cadvisor metrics now, which are the most important ones probably.
Maybe we can first point out the injection option in the docs and then also the full deployment with the noted caveat that this is just very basic.