Add automated daily workflow for ToolHive model updates

[aponcedeleonch]

• New GitHub Actions workflow runs daily at midnight UTC to check for ToolHive API changes
• Enhanced generate_toolhive_models.sh to automatically manage thv serve lifecycle (starts/stops with cleanup)
• Script now detects timestamp-only changes and skips updates when no meaningful changes exist
• Outputs specific filenames where changes were detected for better visibility
• Workflow creates PRs automatically only when meaningful changes are found
• Pinned toolhive-actions version to v0.0.3 for consistency across workflows

[claude]

Pull Request Review

This PR adds automated daily checks for ToolHive API changes with smart change detection. Overall, this is a well-structured improvement with good automation practices.

Strengths

1. Excellent Script Improvements - Proper lifecycle management with cleanup trap, smart change detection excluding timestamp-only updates, good safety checks, and clear user feedback
2. Well-Configured Workflow - Pinned action versions with commit SHAs for security, appropriate permissions, automatic PR creation only when meaningful changes exist, good error handling
3. Proper Integration - Script moved to scripts/ directory, integration tests workflow updated consistently

High Priority Issues

1. Missing Workflow Output Check - The script exits with code 0 when no meaningful changes are detected, but the workflow unconditionally creates a PR. This means empty PRs may be created when only timestamps change.
2. Workflow Branch Conflict Risk - Uses fixed branch name update-thv-models. If workflow runs while previous PR is open, it will force-push to the same branch.
3. Script Race Condition - Uses curl to check if server is ready, but only checks for successful connection. The OpenAPI endpoint might not be fully initialized.

Medium Priority Issues

4. No Tests for Script - The bash script has complex logic but no tests
5. Workflow Notification Issues - Issue creation on failure may create duplicate issues
6. Security: Port Hardcoding - Port 8080 is hardcoded and could conflict with existing services

Security & Performance

• Good: Actions are pinned to commit SHAs
• Good: GITHUB_TOKEN is used appropriately with minimal required permissions
• Good: set -euo pipefail prevents silent failures
• Good: OUTPUT_DIR validation prevents accidental dangerous deletions
• Good: 30-second timeout and backup/restore mechanism are efficient

Overall Assessment

Verdict: Approve with minor changes recommended

This PR demonstrates good engineering practices with proper error handling, cleanup, and automation. The main concern is the workflow potentially creating empty PRs when no meaningful changes are detected. I recommend addressing high-priority issue #1 before merging.

The other issues are nice-to-haves that can be addressed in follow-up PRs if needed.

[aponcedeleonch]

@claude check again the newest commit. Verify if the fixes were applied. Make your comment short and precise

[claude]

Claude finished @aponcedeleonch's task —— View job

---

Verification Complete ✓

All high-priority issues addressed:

1. ✓ Empty PR prevention - Workflow now checks for changes (lines 46-55) and only creates PR when has_changes=true (line 58)

2. ✓ Branch conflict resolved - Uses unique branch name update-thv-models-${{ github.run_id }} (line 67) instead of fixed name

3. ✓ Race condition fixed - Script validates JSON response and checks for "openapi" string (line 38) before proceeding

Additional improvements observed:

• Script exits with code 0 when no meaningful changes detected (line 132), properly syncing with workflow check
• Concurrency control added to prevent parallel runs (lines 14-16)
• Process existence check before kill (line 15)

Recommendation: Ready to merge ✅

---

Job Run • Branch: ci-generate-thv-models

[therealnb]

This looks cool.

Would another cool thing be to get claude to fix potential breakages to the code and push that? i.e. have another specific claude review.