feat: gitea backend #325

denyskon · 2023-01-10T20:44:52Z

netlify · 2023-01-10T20:44:58Z

✅ Deploy Preview for demo-staticjscms ready!

Name	Link
🔨 Latest commit	`8028d75`
🔍 Latest deploy log	https://app.netlify.com/sites/demo-staticjscms/deploys/63c716cf9bcf7f0008ee210e
😎 Deploy Preview	https://deploy-preview-325--demo-staticjscms.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-01-10T20:44:58Z

✅ Deploy Preview for staticjscms ready!

Name	Link
🔨 Latest commit	`8028d75`
🔍 Latest deploy log	https://app.netlify.com/sites/staticjscms/deploys/63c716cff5ca7e000859891f
😎 Deploy Preview	https://deploy-preview-325--staticjscms.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

denyskon · 2023-01-10T20:55:02Z

Login, initial collection loading and media library are working. When opening a collection item, I get some weird issue where the media_folder gets split into single characters and sent as single requests, I'll take another look at it tomorrow......

KaneFreeman · 2023-01-12T19:22:28Z

I get some weird issue where the media_folder gets split into single characters and sent as single requests

That was a different bug that was fixed in beta 11. Please update your branch and test again.

denyskon · 2023-01-12T19:47:31Z

I get some weird issue where the media_folder gets split into single characters and sent as single requests

That was a different bug that was fixed in beta 11. Please update your branch and test again.

Thanks, that is working now. I had a temporary fix, for that, but I rebased to main now.

I have two issues I don't know the structure good enough to understand them:

Loading the collection items works fine, but the link to the item when clicking on a tile has the folder path in it for some reason. Example:

The media tab on the homepage is working fine, but any media library popup when editing an entry says no media found.

Do you have any ideas what the reason could be? @KaneFreeman

packages/core/src/backends/gitea/__tests__/API.spec.ts

+      expect(fetch).toHaveBeenCalledWith('https://api.github.com/some-path', {
+        cache: 'no-cache',
+        headers: {
+          Authorization: 'token token',


packages/core/src/backends/gitea/__tests__/API.spec.ts

+      const api = new API({ branch: 'gh-pages', repo: 'my-repo', token: 'token' });
+
+      api.requestHeaders = jest.fn().mockResolvedValue({
+        Authorization: 'promise-token',


packages/core/src/backends/gitea/__tests__/API.spec.ts

+      expect(fetch).toHaveBeenCalledWith('https://api.github.com/some-path', {
+        cache: 'no-cache',
+        headers: {
+          Authorization: 'promise-token',


denyskon · 2023-01-15T21:43:56Z

Tests are a hell, but seems like it's ready. @KaneFreeman could you take a look, and merge if everything is okay?

KaneFreeman

Looks like you have a few linting/formatting issues. Please run yarn format to correct those.

KaneFreeman · 2023-01-17T13:12:44Z

packages/docs/content/docs/backends-overview.mdx

+| branch        | string                                                                                                  | `main`                                                                                                                                                                                         | _Optional_. The branch where published content is stored. All CMS commits and PRs are made to this branch                                                        |
+| api_root      | string                                                                                                  | GitHub<br />`https://api.github.com`<br /><br />GitLab<br/>`https://gitlab.com/api/v4`<br /><br />Bitbucket<br />`https://api.bitbucket.org/2.0`<br />Gitea<br />`https://try.gitea.io/api/v1` | _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab                                                 |
+| site_domain   | string                                                                                                  | `location.hostname`<br /><br />On `localhost`<br />`cms.netlify.com`                                                                                                                           | _Optional_. Sets the `site_id` query param sent to the API endpoint. Non-Netlify auth setups will often need to set this for local development to work properly  |
+| base_url      | string                                                                                                  | GitHub or Bitbucket<br />`https://api.netlify.com`<br /><br />GitLab<br />`https://gitlab.com`                                                                                                 | _Optional_. OAuth client hostname (just the base domain, no path). **Required** when using an external OAuth server or self-hosted GitLab/GiteaAuthenticationPage|


Suggested change

| base_url | string | GitHub or Bitbucket `https://api.netlify.com` GitLab `https://gitlab.com` | _Optional_. OAuth client hostname (just the base domain, no path). **Required** when using an external OAuth server or self-hosted GitLab/GiteaAuthenticationPage|

| base_url | string | GitHub or Bitbucket `https://api.netlify.com` GitLab `https://gitlab.com` | _Optional_. OAuth client hostname (just the base domain, no path). **Required** when using an external OAuth server or self-hosted GitLab/Gitea|

KaneFreeman · 2023-01-17T13:14:55Z

packages/docs/content/docs/backends-overview.mdx

+| name          | 'git-gateway'<br />\| 'github'<br />\| 'gitlab'<br />\| 'bitbucket'<br />\| 'gitea'<br />\|'test-repo'<br />\| 'proxy' |                                                                                                                                                                                 | The backend git provider                                                                                                                                         |
+| repo          | string                                                                                                  |                                                                                                                                                                                                | Required for `github`, `gitlab`, `gitea` and `bitbucket` backends. Ignored by `git-gateway`. Follows the pattern `[org-or-username]/[repo-name]`                 |
+| branch        | string                                                                                                  | `main`                                                                                                                                                                                         | _Optional_. The branch where published content is stored. All CMS commits and PRs are made to this branch                                                        |
+| api_root      | string                                                                                                  | GitHub<br />`https://api.github.com`<br /><br />GitLab<br/>`https://gitlab.com/api/v4`<br /><br />Bitbucket<br />`https://api.bitbucket.org/2.0`<br />Gitea<br />`https://try.gitea.io/api/v1` | _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab                                                 |


Small formatting issue here.

Suggested change

| api_root | string | GitHub `https://api.github.com` GitLab `https://gitlab.com/api/v4` Bitbucket `https://api.bitbucket.org/2.0` Gitea `https://try.gitea.io/api/v1` | _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab |

| api_root | string | GitHub `https://api.github.com` GitLab `https://gitlab.com/api/v4` Bitbucket `https://api.bitbucket.org/2.0` Gitea `https://try.gitea.io/api/v1` | _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab |

KaneFreeman · 2023-01-17T13:17:31Z

packages/docs/content/docs/gitea-backend.mdx

+---
+title: Gitea
+group: Backends
+weight: 70


This should appear before Local Backend (which has a weight of 50).

Suggested change

weight: 70

weight: 45

KaneFreeman · 2023-01-17T13:19:46Z

packages/core/src/backends/gitea/__tests__/implementation.spec.ts

+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+declare const global: any;
+
+describe('github backend implementation', () => {


Can we clean up the use of github throughout the tests.

KaneFreeman · 2023-01-17T13:37:40Z

packages/docs/content/docs/gitea-backend.mdx

@@ -0,0 +1,47 @@
+---
+title: Gitea
+group: Backends


Please add

beta: true

This will mark this whole documentation page (and the gitea backend) as beta.

denyskon force-pushed the feature/gitea branch from 964355a to 1f23fe3 Compare January 12, 2023 19:32

denyskon changed the title ~~WIP: Feature/gitea~~ feat: Feature/gitea [WIP] Jan 12, 2023

github-advanced-security bot found potential problems Jan 12, 2023

View reviewed changes

denyskon force-pushed the feature/gitea branch from a649268 to d343fa8 Compare January 14, 2023 12:54

denyskon added 5 commits January 15, 2023 22:41

WIP

7b0b3b9

WIP

e8634e1

cleanups

1e49f02

linter

59f869c

finilization, cleanups, docs, tests

a72a6ca

denyskon force-pushed the feature/gitea branch from d343fa8 to a72a6ca Compare January 15, 2023 21:42

denyskon changed the title ~~feat: Feature/gitea [WIP]~~ feat: Feature/gitea Jan 15, 2023

denyskon changed the title ~~feat: Feature/gitea~~ feat: gitea backend Jan 15, 2023

KaneFreeman suggested changes Jan 17, 2023

View reviewed changes

requested pr fixes

8028d75

KaneFreeman approved these changes Jan 17, 2023

View reviewed changes

KaneFreeman merged commit 63496b0 into StaticJsCMS:main Jan 17, 2023

denyskon deleted the feature/gitea branch January 19, 2023 22:07

	\| base_url \| string \| GitHub or Bitbucket<br />`https://api.netlify.com`<br /><br />GitLab<br />`https://gitlab.com` \| _Optional_. OAuth client hostname (just the base domain, no path). Required when using an external OAuth server or self-hosted GitLab/GiteaAuthenticationPage\|
	\| base_url \| string \| GitHub or Bitbucket<br />`https://api.netlify.com`<br /><br />GitLab<br />`https://gitlab.com` \| _Optional_. OAuth client hostname (just the base domain, no path). Required when using an external OAuth server or self-hosted GitLab/Gitea\|

	\| api_root \| string \| GitHub<br />`https://api.github.com`<br /><br />GitLab<br/>`https://gitlab.com/api/v4`<br /><br />Bitbucket<br />`https://api.bitbucket.org/2.0`<br />Gitea<br />`https://try.gitea.io/api/v1` \| _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab \|
	\| api_root \| string \| GitHub<br />`https://api.github.com`<br /><br />GitLab<br/>`https://gitlab.com/api/v4`<br /><br />Bitbucket<br />`https://api.bitbucket.org/2.0`<br /><br />Gitea<br />`https://try.gitea.io/api/v1` \| _Optional_. The API endpoint. Only necessary in certain cases, like with GitHub Enterprise or self-hosted GitLab \|

feat: gitea backend #325

feat: gitea backend #325

Uh oh!

Conversation

denyskon commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for demo-staticjscms ready!

Uh oh!

netlify bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for staticjscms ready!

Uh oh!

denyskon commented Jan 10, 2023

Uh oh!

KaneFreeman commented Jan 12, 2023

Uh oh!

denyskon commented Jan 12, 2023

Uh oh!

Check failure

Check failure

Check failure

denyskon commented Jan 15, 2023

Uh oh!

KaneFreeman left a comment

Choose a reason for hiding this comment

Uh oh!

KaneFreeman Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

KaneFreeman Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

KaneFreeman Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

KaneFreeman Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

KaneFreeman Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

denyskon commented Jan 10, 2023 •

edited

Loading

netlify bot commented Jan 10, 2023 •

edited

Loading

netlify bot commented Jan 10, 2023 •

edited

Loading