Fix Orbital Tag missing poker hand, expand add_tag function (#1007)

* `SMODS.smart_add_tag`

* Initialize `G.GAME.orbital_choices`

I should've tested it earlier.

* Add assertion

* Revise LSP def

* Move util function to patch/override

`add_tag` now accepts a table input.

* Remove default `blind_type`

Author: HuyTheKiller

lovely/tag.toml

@@ -39,6 +39,30 @@ payload = '''
     end
 '''
 
+# Orbital Tag's set_ability
+# Initialize fallback Poker Hand
+[[patches]]
+[patches.pattern]
+target = "tag.lua"
+pattern = '''
+elseif self.ability.blind_type then
+    if G.GAME.orbital_choices and G.GAME.orbital_choices[G.GAME.round_resets.ante][self.ability.blind_type] then
+        self.ability.orbital_hand = G.GAME.orbital_choices[G.GAME.round_resets.ante][self.ability.blind_type]       
+    end
+end
+'''
+position = 'after'
+match_indent = true
+payload = '''
+if self.ability.orbital_hand == '['..localize('k_poker_hand')..']' then
+    local _poker_hands = {}
+    for k, v in pairs(G.GAME.hands) do
+        if SMODS.is_poker_hand_visible(k) then _poker_hands[#_poker_hands+1] = k end
+    end
+    self.ability.orbital_hand = pseudorandom_element(_poker_hands, pseudoseed('orbital'))
+end
+'''
+
 # create_UIBox_your_collection_tags()
 [[patches]]
 [patches.regex]

src/overrides.lua

@@ -2410,4 +2410,15 @@ function Card:set_ability(center, initial, delay_sprites)
 	if not initial and G.STATE ~= G.STATES.SMODS_BOOSTER_OPENED and G.STATE ~= G.STATES.SHOP and not G.SETTINGS.paused or G.TAROT_INTERRUPT then
 		SMODS.calculate_context({setting_ability = true, old = old_center.key, new = self.config.center_key, other_card = self, unchanged = old_center.key == self.config.center.key})
 	end
+end
+
+local add_tag_ref = add_tag
+function add_tag(_tag)
+	_tag = _tag or {}
+	_tag.key = _tag.key or 'unknown'
+	assert(G.P_TAGS[_tag.key], ("Could not find tag \"%s\"."):format(_tag.key))
+	if not (_tag.is and _tag:is(Tag)) then
+		_tag = Tag(_tag.key, nil, _tag.blind_type)
+	end
+	add_tag_ref(_tag)
 end