Update Fileshare Sample #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-vmware
reviewed
Apr 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
- nicer scripts - cleaner code - catch attempted uploads of files > 128MB - time-based upload file names - use IOptions to hold fileshare info - mention
This comment was marked as resolved.
This comment was marked as resolved.
bart-vmware
requested changes
Apr 2, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
- rename create-user script to add-user - FolderPath => SharePath - add hostedservice to manage fileshare connection, drop IOptions - add build badge - it's prettier
bart-vmware
reviewed
Apr 4, 2025
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
This was referenced Apr 4, 2025
- HTTP DELETE - build badge `/` encoding - move project readme up a couple levels - file share config in singleton object - use a ViewModel for upload
bart-vmware
reviewed
Apr 7, 2025
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- table for uploaded files - js formatting
bart-vmware
reviewed
Apr 8, 2025
bart-vmware
approved these changes
Apr 10, 2025
bart-vmware
reviewed
Apr 10, 2025
bart-vmware
added a commit
that referenced
this pull request
Jul 22, 2025
* Add Valkey to Redis samples, update broken links (#385) * Add Valkey to Redis samples * Update links to Cloud Foundry and brokers * Update pivotal links * Update getting started links for TAP * Update links to v3 docs, remove links to guides * Fix remaining links * Update links to CF CLI * Update SSO links * Update TAP links * Replace Kubernetes prerequisite with Tanzu CLI * Update Fileshare Sample (#386) * Replace FileShare sample with new .NET 8 app * Add fileshare integration test, ability to skip logging during service creation * Apply suggestions from code review Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com> * Address feedback - nicer scripts - cleaner code - catch attempted uploads of files > 128MB - time-based upload file names - use IOptions to hold fileshare info - mention * Apply suggestions from code review Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com> * address PR Feedback - rename create-user script to add-user - FolderPath => SharePath - add hostedservice to manage fileshare connection, drop IOptions - add build badge - it's prettier * Apply suggestions from code review Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com> * PR feedback - HTTP DELETE - build badge `/` encoding - move project readme up a couple levels - file share config in singleton object - use a ViewModel for upload * Apply suggestions from code review Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com> * PR feedback - table for uploaded files - js formatting * fix badge, don't set ASPNETCORE_ENVIRONMENT * use DiskSpaceHealthContibutor instead of FileShareHealthContributor * skip configuring (a too-old version of) Ruby --------- Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com> * Update sample for Spring Boot Admin registration (#387) * Fix broken endpoint for health group in .http file (#388) * Fix broken links in FileShares readme (#389) * Add/update baseline .cfignore files (#390) * Add/update baseline .cfignore files * delete .dockerignore and .tanzuignore * Update connector samples (#393) * Remove Cloud Foundry support from CosmosDB sample * Update MongoDB sample * Update MySQL samples * Update PostgreSQL samples * Update RabbitMQ sample * Update Redis sample * Update SQL Server sample * Update Redis security sample to show DPAPI keys (#395) * Update Redis security sample to show DPAPI keys * Reformat file using Rider * Bump urllib3 from 2.2.2 to 2.5.0 Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.2 to 2.5.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.2...2.5.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump requests from 2.32.0 to 2.32.4 Bumps [requests](https://github.com/psf/requests) from 2.32.0 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.0...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Add a console/worker app for certificate auth (#391) * Update code fences in READMEs (#396) * Update references to new dev feed (#399) * Update references to new dev feed * Updates version pattern in project references * Auto-sync DotSettings files from Steeltoe v4-rc * Update `cf create-service` commands, fix cloud brokers * add placeholder workflows * Update referenced Steeltoe version to 4.x * Update FileShares sample for 4.x --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim Hess <tim.hess@broadcom.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the last remaining sample app to .NET 8, using the quality guidelines in #334