Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnlineQueries with QtWebEngine #1938

Merged
merged 22 commits into from
Oct 20, 2021
Merged

OnlineQueries with QtWebEngine #1938

merged 22 commits into from
Oct 20, 2021

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Sep 29, 2021 •
edited
Loading

Description

The OnlineQueries plugin currently can only display HTML text. This branch should allow to display remote web content including images. The QtWebEngine module brings in Chromium-based web browser building blocks.

However, it does not embed into our usual StelDialog widgets. Therefore a new StelDialogSeparate allows stand-alone windows. This is even helpful as it allows moving this webbrowser window (which users may enlarge to take a major part of the screen) to a second screen.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: (Windows 10)
  • Graphics Card: irrelevant

Checklist:

Things that should work:

  • Night Mode
  • Resizing with storage of new position
  • Web navigation with back/forward mouse buttons
  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti
Simplified list definition
ffe4ff6
@gzotti
Add QtWebengine and -Widgets modules
e805a30
@gzotti
Add definitions for accessing a QWebEngineView
4b5abbb
@gzotti
Problematic interface file.
cf2d330 
This should add a QWebengineView to the GUI.
However, when calling the window, it vanishes immediately.
It is not even yet used currently!
The editor shows red "invalid layout" icons. How to fix that?
@gzotti gzotti added the enhancement Improve existing functionality label Sep 29, 2021
@gzotti gzotti added this to the 0.21.3 milestone Sep 29, 2021
@gzotti gzotti self-assigned this Sep 29, 2021
@github-actions
Copy link

Hello @gzotti! Thank you for this enhancement.

@github-actions
Copy link

github-actions bot commented Sep 29, 2021 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files

@gzotti
Copy link
Member Author

gzotti commented Oct 16, 2021 •
edited
Loading

OK, we can display queries in our own webview in a separate window. @alex-w Shall we still keep the option to call the system webbrowser?
There is also now no need to extend any configuration buttons. I could replace the tabs by direct buttons. Ideas?

@alex-w
Copy link
Member

alex-w commented Oct 18, 2021

OK, we can display queries in our own webview in a separate window. @alex-w Shall we still keep the option to call the system webbrowser?

I think no need to call external browser for it

There is also now no need to extend any configuration buttons. I could replace the tabs by direct buttons. Ideas?

Good idea - one tab and collection of buttons

@todo

This comment has been minimized.

Sign in to view
@gzotti gzotti marked this pull request as ready for review October 19, 2021 18:25
@github-actions github-actions bot requested a review from alex-w October 19, 2021 18:26
alex-w
alex-w approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for me, thanks!

@alex-w alex-w merged commit 0e7f2b1 into master Oct 20, 2021
@alex-w alex-w deleted the onlinequeries-webengine branch October 20, 2021 12:49
@github-actions
Copy link

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @gzotti! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-w alex-w alex-w approved these changes

Assignees

@gzotti gzotti

Labels
enhancement Improve existing functionality
Milestone
0.21.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gzotti @alex-w