Skip to content

Fix split count extraction bugs #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Fix split count extraction bugs #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9949a7
Fixed split count extraction bugs
andrewherren Oct 16, 2025
2100c1b
Made variable names match
andrewherren Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/forest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,8 +770,9 @@ cpp11::writable::integers get_overall_split_counts_active_forest_cpp(cpp11::exte
StochTree::Tree* tree = active_forest->GetTree(i);
std::vector<int32_t> split_nodes = tree->GetInternalNodes();
for (int j = 0; j < split_nodes.size(); j++) {
auto split_feature = split_nodes.at(j);
output.at(split_feature)++;
auto node_id = split_nodes.at(j);
auto feature_split = tree->SplitIndex(node_id);
output.at(feature_split)++;
}
}
return output;
Expand All @@ -786,8 +787,9 @@ cpp11::writable::integers get_granular_split_count_array_active_forest_cpp(cpp11
StochTree::Tree* tree = active_forest->GetTree(i);
std::vector<int32_t> split_nodes = tree->GetInternalNodes();
for (int j = 0; j < split_nodes.size(); j++) {
auto split_feature = split_nodes.at(j);
output.at(split_feature*num_trees + i)++;
auto node_id = split_nodes.at(j);
auto feature_split = tree->SplitIndex(node_id);
output.at(feature_split*num_trees + i)++;
}
}
return output;
Expand Down
3 changes: 2 additions & 1 deletion src/py_stochtree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,8 @@ class ForestContainerCpp {
StochTree::Tree* tree = ensemble->GetTree(tree_num);
std::vector<int32_t> split_nodes = tree->GetInternalNodes();
for (int i = 0; i < split_nodes.size(); i++) {
auto split_feature = split_nodes.at(i);
auto node_id = split_nodes.at(i);
auto split_feature = tree->SplitIndex(node_id);
accessor(split_feature)++;
}
return result;
Expand Down
Loading