Skip to content

Conversation

@GeForceLegend
Copy link
Contributor

Added compute shader with suffixes linting;
Fixed icon unable to load;
Fixed shields in readme;
Updated to latest rust nightly (or I will not able to compile it on my computer).

Notice: since I'm new in rust, I don't know if std::cell::OnceCell is same with std::lazy::OnceCell, but my rust version (latest nightly when i set it up yesterday) does not contain lazy. I just modded it to pass compiling and doesn't see extra bugs yet. Please check this before merge.

Personal advice: maybe you can delete the dependency to let users choose their own GLSL syntax extension. At least I prefer working with mine, but since this extension depends on vscode-shaders, and his GLSL syntax will override mine, I have to copy my syntax file into his extension in my device to use both my syntax highlight and your language server.

I'm not sure if these 2 packages are same since I can't find any document direct to std::lazy::OnceCell
Compute shader with _a to _z suffix can get highlighted now
@Strum355
Copy link
Owner

Thanks for the PR. I've been slow to get back to things due to being very busy at work and not satisfied with how the code is shaping out in https://github.com/Strum355/mcshader-lsp/tree/rust/lsp-tower. Ill cut a release with these changes (and the others) to hopefully get things rolling again. Would be a shame for this project to not continue

Personal advice: maybe you can delete the dependency to let users choose their own GLSL syntax extension. At least I prefer working with mine, but since this extension depends on vscode-shaders, and his GLSL syntax will override mine, I have to copy my syntax file into his extension in my device to use both my syntax highlight and your language server.

I might just use your grammar instead anyways, I dont like the direction the other one has gone.

Notice: since I'm new in rust, I don't know if std::cell::OnceCell is same with std::lazy::OnceCell, but my rust version (latest nightly when i set it up yesterday) does not contain lazy. I just modded it to pass compiling and doesn't see extra bugs yet. Please check this before merge.

std::cell::OnceCell seems to be the new name (not sure when this change happened).

@Strum355 Strum355 merged commit fb12c9b into Strum355:rust-rewrite Feb 12, 2023
@GeForceLegend
Copy link
Contributor Author

We know that you are busy, so I'm working on modifying it for my own use (though I may share builded file to other for testing). You can find what I have done in my attempt in writing a new file system and a tower-lsp rewrite too. Thanks Fayer3 for the work space code.
If you find anything interesting in my fork and new repo, feel free to use them. My rewrite with tower-lsp is not thread-safe for now, though it can do linting and document links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants