Add support for golangci-lint version 2 #9
Conversation
eread
force-pushed
the
eread/add-support-for-golangci_lint-version-2
branch
2 times, most recently
from
244ba55 to
2e0ac76
Compare
| class GolangCILint(Linter): | ||
| cmd = 'golangci-lint run ${args} --out-format tab ${file_path}' | ||
| def cmd(self): | ||
| if self.settings.get("v1", False): |
There was a problem hiding this comment.
@kaste This is still too magical. Do we need to run golangci-lint version somehow and regex the version out of what's returned?
There was a problem hiding this comment.
Right now, that would be just a manual setting. We would need to add that to the README and then the release notes.
Of course it would be possible to automate this, let me sketch that out. Let's see if I get that just out of my head:
import shutil
from SublimeLinter.lint import util
# first resolve the executable
if binary:= shutil.which("golangci"):
stdout: str = util.check_output([binary, "<whatever arg it takes to return the version>"])
# parse stdout with a regex or simpler if stdout.startswith("1.")There was a problem hiding this comment.
@kaste Thanks! It occurred to me only later that we were creating a new setting. I actually like the idea of making it just a setting. Very light weight and robust.
I've pushed up some more changes. What do you think now?
eread
force-pushed
the
eread/add-support-for-golangci_lint-version-2
branch
from
2e0ac76 to
e73e398
Compare
|
Released as 3.0.0 🚀 |
Thanks @kaste! 🤝 |
|
Given that this I suggest to automatically detect version based on |
|
v1 is actually a linter setting, so you can set it in a project file or per syntax or directly on a view. We should have added it to the defaults dict to make that clear. And also to ensure we have a default set at any time. |
|
I won't be polluting my projects with sublime text project files. This version detection should be automatic imho, and the config option should serve as a (non-recommended) override. |
@silverwind That would be an excellent enhancement. You could raise a pull request for that? My pull request was a first simple step. |
3 participants
With the release of
golangci-lintversion 2, some changes are needed to this package.