Skip to content

Conversation

@guilhermesimoes
Copy link
Collaborator

Since ruby -wc does not return column numbers, the best we can do for now is parse the warning messages and highlight some text tokens.

Before:
screen shot 2017-05-04 at 16 40 23

After:
screen shot 2017-05-04 at 16 39 17

@guilhermesimoes
Copy link
Collaborator Author

This is still a WIP as I may have missed a few other warnings that can also be highlighted.

Since `ruby -wc` does not return column numbers, the best we can do for
now is parse the warning messages and highlight some text tokens.
@guilhermesimoes
Copy link
Collaborator Author

Everything should be good now!

@kaste
Copy link
Member

kaste commented May 6, 2018

Hi. Sorry this repo obviously had no maintainer at that time.

LGTM. @braver ship it!?

@braver
Copy link
Member

braver commented May 6, 2018

I don’t know anything about Ruby or these changes. I’ll ship it and give @guilhermesimoes access to the repo so he can perhaps make changes later if the need arises.

@braver braver merged commit 0fa04d9 into SublimeLinter:master May 6, 2018
@guilhermesimoes guilhermesimoes deleted the highlight-tokens branch May 9, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants