-
Notifications
You must be signed in to change notification settings - Fork 81
A sizable refactor #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
michaelblyons
wants to merge
62
commits into
SublimeText:master
Choose a base branch
from
michaelblyons:refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
A sizable refactor #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Param and function metadata respectively
13 tasks
Rather than triggering on Add-Type
8f57f8c to
be42068
Compare
And make sure it doesn't make hashtables
Collaborator
Author
|
@matteocoder Do you want to give this a try? Let me know if there are big regressions. |
bf35175 to
a671c6f
Compare
I think this language was written by trolls.
a671c6f to
649687a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test if you are so inclined!
This is mostly organization and restriction of scopes according to a distinguishing of
expressionsand a newstatementscontext. All pre-existing tests pass, but there may be bugs that we didn't have tests for.New
Changed
statementscontext restricts some contexts that were being nested everywhere. This is the most likely place to find bugs.usingimports can now only come at the top of the file, as the docs specify.Maybe
Verb-Nounbecause we know it must be a command)